Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing an assert in GetGCMemoryInfo #87848

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

Maoni0
Copy link
Member

@Maoni0 Maoni0 commented Jun 20, 2023

when there hasn't been any GC of that kind yet, we cannot validate the info as it's all 0's.

@ghost
Copy link

ghost commented Jun 20, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

when there hasn't been any GC of that kind yet, we cannot validate the info as it's all 0's.

Author: Maoni0
Assignees: Maoni0
Labels:

area-GC-coreclr

Milestone: -

@mangod9
Copy link
Member

mangod9 commented Jun 20, 2023

there is a GCC build break, probably needs a cast to unsigned.

/__w/1/s/src/coreclr/nativeaot/Runtime/../../gc/env/volatile.h: In instantiation of ‘bool Volatile<T>::operator!=(const TOther&) const [with TOther = int; T = long unsigned int]’: /__w/1/s/src/coreclr/gc/gc.cpp:50274:32: required from here

@Maoni0
Copy link
Member Author

Maoni0 commented Jun 20, 2023

yeah, I have a fix. just haven't pushed it yet.

@Maoni0 Maoni0 merged commit 9963dd1 into dotnet:main Jun 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants