Fix metrics test #87898
Merged
Fix metrics test #87898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
tarekgh
added
area-System.Diagnostics.Metric
and removed
needs-area-label
JamesNK
approved these changes
Jun 22, 2023
noahfalk
approved these changes
Jun 22, 2023
| int lastMeasurement = 0; | ||
| listener.SetMeasurementEventCallback<int>((inst, measurement, tags, state) => lastMeasurement = measurement); | ||
| listener.EnableMeasurementEvents(counter, null); | ||
| listener.Start(); |
There was a problem hiding this comment.
You also don't need to call Start() if you aren't listening to publish events.
stephentoub
reviewed
Jun 22, 2023
src/libraries/Microsoft.Extensions.Diagnostics/tests/MetricsTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 22, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the comment #87873 (review)