Fix ABIStress test hashing padding #88097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABIStress was including padding in its hashing when trying to determine if all values made it through correctly. Make sure we only hash the fields that actually store data.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsABIStress was including padding in its hashing when trying to determine if all values made it through correctly. Make sure we only hash the fields that actually store data. With physical promotion enabled this causes the test to fail. That's because of this type: runtime/src/tests/JIT/Stress/ABI/Types.cs Line 65 in 19d2e90 which has 15 bytes of padding in it. I verified that regular promotion also causes the test to fail if a type is added that is regularly promoted, e.g. with
|
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABIStress was storing data inside of padding and hashing it when trying to determine if all values made it through correctly. Make sure we only hash the fields.
With physical promotion enabled this causes the test to fail. That's because of this type:
runtime/src/tests/JIT/Stress/ABI/Types.cs
Line 65 in 19d2e90
which has 15 bytes of padding in it. When the constructor is invoked, a temp is created, and physical promotion ends up promoting that temp and only writing the significant "field" parts.
I verified that regular promotion also causes the test to fail if a type is added that is regularly promoted, e.g. with
struct S { public byte F0; public long F1; }the same problem is hit on main.