Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SearchValues<string> #88394

Merged
merged 43 commits into from
Aug 20, 2023
Merged

Add SearchValues<string> #88394

merged 43 commits into from
Aug 20, 2023

Commits on Aug 4, 2023

  1. Add SearchValues<string>

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1566d85 View commit details
    Browse the repository at this point in the history

  2. Fix AhoCorasickNode DebuggerDisplay

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c56168d View commit details
    Browse the repository at this point in the history

  3. Typos & rewordings

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    68d3dfd View commit details
    Browse the repository at this point in the history

  4. Use [InlineArray]

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    515104c View commit details
    Browse the repository at this point in the history

  5. Simplify NLS variant of AhoCorasick

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2a5bef5 View commit details
    Browse the repository at this point in the history

  6. Remove 2 TODOs

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7dc3186 View commit details
    Browse the repository at this point in the history

  7. Add a few more simple test cases

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3f99c76 View commit details
    Browse the repository at this point in the history

  8. Add BurntSushi/aho-corasick to THIRD-PARTY-NOTICES

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b412fd9 View commit details
    Browse the repository at this point in the history

  9. Add more rng to stress runs

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7f8bae2 View commit details
    Browse the repository at this point in the history

  10. Remove DebuggerDisplay on AhoCorasickNode

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c558404 View commit details
    Browse the repository at this point in the history

  11. More comments around AhoCorasickNode.TryCreateJumpTable

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    15996f4 View commit details
    Browse the repository at this point in the history

  12. Reduce RabinKarp ctor allocations

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5d4cacc View commit details
    Browse the repository at this point in the history

  13. Move ordinal helpers around a bit

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b8757e4 View commit details
    Browse the repository at this point in the history

  14. Typo

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    822f5c6 View commit details
    Browse the repository at this point in the history

  15. Remove IValueLength

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2e70415 View commit details
    Browse the repository at this point in the history

  16. Dedup some ICaseSensitivity.Equals loops

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    676c461 View commit details
    Browse the repository at this point in the history

  17. Avoid some costs in RabinKarp for long values

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6e31d6e View commit details
    Browse the repository at this point in the history

  18. Remove now-unused maxValueLength field

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    38a6436 View commit details
    Browse the repository at this point in the history

  19. Add comment about MaxCombinedFrequency in AC

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2f7a966 View commit details
    Browse the repository at this point in the history

  20. React to compiler changes to InlineArray

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0685172 View commit details
    Browse the repository at this point in the history

  21. Link the roslyn-analyzers issue

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    57f2c3b View commit details
    Browse the repository at this point in the history

  22. Remove >>> workaround now that dotnet#86841 is merged

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5f46a3a View commit details
    Browse the repository at this point in the history

  23. Improve comments around the Teddy implementation

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9ea4784 View commit details
    Browse the repository at this point in the history

  24. Improve comments around StringSearchValuesHelper

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    73ca19e View commit details
    Browse the repository at this point in the history

  25. Tweak RabinKarp comments

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e672f5f View commit details
    Browse the repository at this point in the history

  26. Improve comments around Aho-Corasick

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    bcf6a8e View commit details
    Browse the repository at this point in the history

  27. Remove some SearchValues indirection

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    de3dedd View commit details
    Browse the repository at this point in the history

  28. Remove AggressiveInlining in a few places

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9d02edb View commit details
    Browse the repository at this point in the history

  29. Improve comments around ThreeChars SearchValues

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3411289 View commit details
    Browse the repository at this point in the history

  30. Fix assert and code typo

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d4f63d6 View commit details
    Browse the repository at this point in the history

  31. Reduce overhead for creating single-value SearchValues

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5cb16fa View commit details
    Browse the repository at this point in the history

  32. Reword TODO to 'Potential optimization'

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e66d8d9 View commit details
    Browse the repository at this point in the history

  33. Add a few more test cases for single values

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    36dc66b View commit details
    Browse the repository at this point in the history

  34. Combine a-z and !Ascii checks

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d4eca96 View commit details
    Browse the repository at this point in the history

  35. Add more asserts around read pointer manipulation

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f457975 View commit details
    Browse the repository at this point in the history

  36. Add a description of the overall Teddy algorithm

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ba5a95b View commit details
    Browse the repository at this point in the history

  37. Improve the Teddy comment a bit more

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    cc7710b View commit details
    Browse the repository at this point in the history

  38. Comment space alignment

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d4e9557 View commit details
    Browse the repository at this point in the history

  39. Add a fallback implementation to deal with incomplete surrogate pairs

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    efdd97a View commit details
    Browse the repository at this point in the history

  40. More edge case tests

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1a3e35d View commit details
    Browse the repository at this point in the history

  41. Add some comments about the time complexity of different implementations

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d1c69eb View commit details
    Browse the repository at this point in the history

  42. Fix NLS test

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    177cc7c View commit details
    Browse the repository at this point in the history

  43. React to compiler and ref readonly changes

    @MihaZupan
    MihaZupan committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6c64e45 View commit details
    Browse the repository at this point in the history