-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that the CpuId tests set preferredVectorByteLength to a non-zero value #88623
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #88581
|
/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
No commit pushedDate could be found for PR 88623 in repo dotnet/runtime |
/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 4 pipeline(s). |
CC. @dotnet/jit-contrib. This resolves #88581 and resolves #88582 and resolves #88580 The two main issues were that Additionally, the check around This fixes both of those issues and ensures the tests are taking the preferred width into account so they pass as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the stress mode might be salvageable somehow, but let's sort that out later.
It's worth noting that we are explicitly testing |
@dotnet-policy-service rerun |
There are still some stress failures, but unrelated to this PR in particular. |
This resolves #88581 and resolves #88582 and resolves #88580