[release/6.0-staging] dotnet.exe prints error messages to console when launched with empty DOTNET_MULTILEVEL_LOOKUP #88664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…DOTNET_MULTILEVEL_LOOKUP
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #84322 to release/6.0-staging Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
This was referenced Jul 11, 2023
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Jul 12, 2023
vitek-karas
approved these changes
Jul 13, 2023
rbhanda
added
Servicing-approved
|
Friendly reminder: if you want this servicing fix to be included in the September 2023 Release, you'll have to merge this PR before August 14th. |
|
@elinor-fung can you take a look what's needed to merge this? |
|
Timeout is unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #84322 to release/6.0-staging
/cc @elinor-fung @pedrobsaila
Customer Impact
The host has a bug where it prints an error, Failed to read environment variable [DOTNET_MULTILEVEL_LOOKUP], HRESULT: 0x800700CB if DOTNET_MULTILEVEL_LOOKUP is an empty string. We've gotten feedback that this is confusing for users - particularly since VS does this.
See #82260, #87687
This fix silences the message.
Note: Not a regression. We think some tool just started setting this more frequently.
Testing
Unit testing, and this change has been in main since April and backported to 7.0 two weeks ago.
Risk
Isolated change, simple if statement.