Remove DelegateInvokeStubManager
#88683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Delegate Invoke scenarios now use the StubLinker. This means there is an inherent confusion between the two stub managers. Upon further inspection combining these two by adding a new flag on the Stub class means they can be combined logically and simplify the code path by removing a StubManager.
|
Tagging subscribers to this area: @tommcdon Issue DetailsAll Delegate Invoke scenarios now use the #Fixes 85339
|
|
/cc @dotnet/dotnet-diag |
This was referenced Jul 11, 2023
hoyosjs
approved these changes
Jul 12, 2023
This was referenced Jul 13, 2023
|
The failures are known. I reran the tests before checking for known issues. |
AustinWise
reviewed
Jul 13, 2023
hoyosjs
approved these changes
Jul 13, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Delegate Invoke scenarios now use the
StubLinker. This means there is an inherent confusion between the two stub managers. Upon further inspection combining these two by adding a new flag on theStubclass means they can be combined logically and simplify the code path by removing aStubManager.Fixes #85339