[wasm] [testing] Allocate a bunch of memory before exiting #88702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e are to the limit
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWe seem to be close to the memory limit for some of our test suites, so see whether we can allocate a bunch of memory before exit.
|
|
Library tests passed with a ~160mb allocation at the end, so it's mysterious that #88279 is maxing out v8's allocated memory at 2gb. I don't know what's going on there, will have to try and come up with theories for how we could be using so much extra memory just from growing the function table. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to be close to the memory limit for some of our test suites, so see whether we can allocate a bunch of memory before exit.