Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-in changes to generated file #88741

Merged

Conversation

mrvoorhe
Copy link
Contributor

I don't know anything about this file but when I build illink.sln this file is modified. I'm guessing these changes should be checked in?

I don't know anything about this file but when I build illink.sln this file is modified.  I'm guessing these changes should be checked in?
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 12, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 12, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 12, 2023
@mrvoorhe
Copy link
Contributor Author

@vitek-karas Should these changes be checked in?

@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

I don't know anything about this file but when I build illink.sln this file is modified. I'm guessing these changes should be checked in?

Author: mrvoorhe
Assignees: -
Labels:

linkable-framework, needs-area-label

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this change as part of #88268, but unfortunately that PR takes longer than I expected.

Thanks for fixing this.

@lewing
Copy link
Member

lewing commented Jul 13, 2023

failures are unrelated

@lewing lewing merged commit f1ea95a into dotnet:main Jul 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants