Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting #89020

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[release/6.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting #89020

merged 1 commit into from
Jul 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 17, 2023 •
edited by vcsjones
Loading

Backport of #88854 to release/6.0-staging

/cc @vcsjones

This is a test only change to skip RC2 tests on Android.

Closes #88747

@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #88854 to release/6.0-staging

/cc @vcsjones

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Security
Milestone: -

@vcsjones vcsjones added the test-bug Problem in test source code (most likely) label Jul 17, 2023
carlossanlop
carlossanlop approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-only change.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jul 17, 2023
@carlossanlop
Copy link
Member

@vcsjones if the CI shows no related failures, let me know and I can merge this for you.

@akoeplinger akoeplinger changed the title [release/6.0-staging] [release/7.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting [release/6.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting Jul 17, 2023
@akoeplinger
Copy link
Member

On 6.0 we used runtime-staging for Android, I checked and the test gets skipped correctly there.

@akoeplinger akoeplinger merged commit 21209de into release/6.0-staging Jul 17, 2023
@akoeplinger akoeplinger deleted the backport/pr-88854-to-release/6.0-staging branch July 17, 2023 19:42
@akoeplinger
Copy link
Member

Thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-System.Security Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @akoeplinger @vcsjones