Skip to content

Avoid unnecessary string allocations in Get/SetMsQuicParameter #89050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 1 commit into from
Jul 18, 2023
Merged

Avoid unnecessary string allocations in Get/SetMsQuicParameter #89050

stephentoub merged 1 commit into from
Jul 18, 2023

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jul 17, 2023

@stephentoub stephentoub requested review from ManickaP and wfurt July 17, 2023 21:19
@ghost ghost added the area-System.Net.Quic label Jul 17, 2023
@ghost ghost assigned stephentoub Jul 17, 2023
@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

#88550 (comment)

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Net.Quic
Milestone: -

wfurt
wfurt approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks.

@stephentoub stephentoub merged commit 4f933e1 into dotnet:main Jul 18, 2023
@stephentoub stephentoub deleted the fixquicalloc branch July 18, 2023 01:13
@karelz karelz added this to the 8.0.0 milestone Aug 1, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes

@ManickaP ManickaP Awaiting requested review from ManickaP

Assignees

@stephentoub stephentoub

Labels

area-System.Net.Quic

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@stephentoub @wfurt @karelz