Add Driver.Context setter #89081
Add Driver.Context setter #89081
Conversation
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
ghost
added
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsWe implement our own In our very old revision of the upstream linker there was Which we would set. This would ensure that if one of the helper methods that uses the context were called that things would all work. The most common scenario seems to be for error logging. There are many helper methods that will call We are syncing up and now the Adding a setter was the easiest way to get our context stored in the
|
We implement our own `Driver.SetupContext`. Our command line parsing logic is different and we have additional command line options. In our very old revision of the upstream linker there was ``` protected LinkContext context; ``` Which we would set. This would ensure that if one of the helper methods that uses the context were called that things would all work. The most common scenario seems to be for error logging. There are many helper methods that will call `Context.LogError` and if we haven't set the `context` field by then we have a problem. We are syncing up and now the `context` field is private and there is a protected property getter, but no setter. Adding a setter was the easiest way to get our context stored in the `context` field.
mrvoorhe
force-pushed
the
linker-expose-context-for-setting
branch
from
5fbca84
to
9c9016c
Compare
We implement our own
Driver.SetupContext. Our command line parsing logic is different and we have additional command line options.In our very old revision of the upstream linker there was
Which we would set. This would ensure that if one of the helper methods that uses the context were called that things would all work. The most common scenario seems to be for error logging. There are many helper methods that will call
Context.LogErrorand if we haven't set thecontextfield by then we have a problem.We are syncing up and now the
contextfield is private and there is a protected property getter, but no setter.Adding a setter was the easiest way to get our context stored in the
contextfield.