Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix perf pipeline #89091

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[wasm] Fix perf pipeline #89091

merged 1 commit into from
Jul 18, 2023

Conversation

radical
Copy link
Member

@radical radical commented Jul 18, 2023

[wasm] Perf - update to track a regression in bdn argument parsing

Passing arguments to bdn as "--wasmArgs=--expose_wasm --module" broke
with the latest update. Now this gets incorrectly parsed. Instead, what
works is: --wasmArgs "--expose_wasm --module".

This resulted in, v8 being passed only the default value of --expose_wasm, and thus perf runs failing with:

[2023/07/18 04:48:37][INFO] test-main.js:7: SyntaxError: Cannot use import statement outside a module
[2023/07/18 04:48:37][INFO] import { dotnet, exit } from './_framework/dotnet.js';
[2023/07/18 04:48:37][INFO] ^^^^^^
[2023/07/18 04:48:37][INFO] SyntaxError: Cannot use import statement outside a module

Passing arguments to bdn as `"--wasmArgs=--expose_wasm --module"` broke
with the latest update. Now this gets incorrectly parsed. Instead, what
works is: `--wasmArgs "--expose_wasm --module"`.
@radical radical added the arch-wasm WebAssembly architecture label Jul 18, 2023
@ghost ghost assigned radical Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Passing arguments to bdn as "--wasmArgs=--expose_wasm --module" broke
with the latest update. Now this gets incorrectly parsed. Instead, what
works is: --wasmArgs "--expose_wasm --module".

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@radical radical changed the title [wasm] Perf - update to track a regression in bdn argument parsing [wasm] Fix perf pipeline Jul 18, 2023
@radical radical added the perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines label Jul 18, 2023
@radical
Copy link
Member Author

radical commented Jul 18, 2023

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this assuming the test run is green

@radical radical marked this pull request as ready for review July 18, 2023 15:46
@radical radical merged commit ee7c253 into dotnet:main Jul 18, 2023
@radical radical deleted the perf-use-rsp-files branch July 18, 2023 15:47
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants