Fix System.BinaryData tests failing in AOT. #89381
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsFixes test failures reported in #88982 (comment) that have been caused by #88480. The failing tests could have easily been converted to source gen, however this is currently blocked by #81702. Given that this is blocking use of
|
eiriktsarpalis
removed
the
needs-area-label
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>$(NetCoreAppCurrent);$(NetFrameworkMinimum)</TargetFrameworks> | |||
| <JsonSerializerIsReflectionEnabledByDefault>true</JsonSerializerIsReflectionEnabledByDefault> | |||
There was a problem hiding this comment.
Would it make sense to add a comment here saying "Convert tests to source gen when #81702 is fixed"?
There was a problem hiding this comment.
I'll follow up with a new PR addressing this now, following the recommendation in #89381 (comment)
|
IMO we should just fast-track the API change. Moving from internal to public when the type merely implements an abstract class should be something we review fast (over email?) - only thing to review is the name and namespace. |
Fixes test failures reported in #88982 (comment) that have been caused by #88480.
The failing tests could have easily been converted to source gen, however this is currently blocked by #81702. Given that this is blocking use of
BinaryDatain source gen we should consider an RC1 fix (which requires change in public API) cc @eerhardt @ericstj