Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] fix the compiling errors within the CLFS linux #89422

Merged
merged 3 commits into from
Jul 26, 2023
Merged

[LoongArch64] fix the compiling errors within the CLFS linux #89422

merged 3 commits into from
Jul 26, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Now the linux-kernel and the llvm had supported the LoongArch, it's time to update the 'struct mcontext_t' and some asm formate.

This patch is to fix the compiling errors within the new OS which is published based on the upstream community liking the Arch-linux and CLFS.

@shushanhf
[LoongArch64] fix the compiling errors after
0395b0d 
the linux-kernel and llvm had supported the LoongArch.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 25, 2023
@shushanhf shushanhf requested a review from am11 July 25, 2023 08:53
@shushanhf shushanhf changed the title [LoongArch64] fix the compiling errors after [LoongArch64] fix the compiling errors within the CLFS linux Jul 25, 2023
am11
am11 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Was it impacted by libunwind update? There were LA's ABI related changes in libunwind 1.7 release.

@shushanhf
Copy link
Contributor Author

Thanks!

Was it impacted by libunwind update? There were LA's ABI related changes in libunwind 1.7 release.

Thanks
I will check it

janvorli
janvorli approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the one comment.

src/coreclr/pal/src/arch/loongarch64/signalhandlerhelper.cpp Outdated Show resolved Hide resolved
@shushanhf
Copy link
Contributor Author

Thanks!
Was it impacted by libunwind update? There were LA's ABI related changes in libunwind 1.7 release.

Thanks I will check it

The libunwind is ok for these.

@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Closed
This was referenced Jul 26, 2023
Closed
Closed
@janvorli janvorli merged commit e1ee453 into dotnet:main Jul 26, 2023
107 checks passed
@shushanhf shushanhf deleted the update_mcontext_t branch July 27, 2023 01:12
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@janvorli janvorli janvorli approved these changes

@am11 am11 am11 approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shushanhf @am11 @janvorli @AaronRobinsonMSFT