Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hits for new analyzer CA1862 #89539

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix hits for new analyzer CA1862 #89539

merged 1 commit into from
Jul 27, 2023

Conversation

carlossanlop
Copy link
Member

Added the ability to diagnose equality comparisons like string.ToLower() == string.ToLower().

dotnet/roslyn-analyzers#6720

@carlossanlop carlossanlop added area-System.Security code-fixer Marks an issue that suggests a Roslyn code fixer labels Jul 26, 2023
@carlossanlop carlossanlop requested a review from buyaa-n July 26, 2023 23:41
@carlossanlop carlossanlop self-assigned this Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the ability to diagnose equality comparisons like string.ToLower() == string.ToLower().

dotnet/roslyn-analyzers#6720

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.Security, code-fixer
Milestone: -

buyaa-n
buyaa-n approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@carlossanlop carlossanlop merged commit 62088e8 into dotnet:main Jul 27, 2023
@carlossanlop carlossanlop deleted the FixCA1862 branch July 27, 2023 01:33
@build-analysis build-analysis bot mentioned this pull request Jul 27, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@vcsjones vcsjones vcsjones approved these changes

Assignees

@carlossanlop carlossanlop

Labels
area-System.Security code-fixer Marks an issue that suggests a Roslyn code fixer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @vcsjones @buyaa-n