Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodejs][http] remove active issue 86326 #89588

Merged
merged 2 commits into from
Jul 29, 2023
Merged

[nodejs][http] remove active issue 86326 #89588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4945e1d
wip
pavelsavara Jul 27, 2023
abaf6a2
Merge branch 'main' into browser_nodejs_http_enable_86326
pavelsavara Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ await TestHelper.WhenAllCompletedOrAnyFailed(

[ConditionalTheory]
[MemberData(nameof(GetAsync_IPBasedUri_Success_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetAsync_IPBasedUri_Success(IPAddress address)
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -1229,7 +1228,6 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStreamAsync_EmptyResponseBody_HandlerProducesWellBehavedResponseStream()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -1399,7 +1397,6 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task Dispose_DisposingHandlerCancelsActiveOperationsWithoutResponses()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -1647,7 +1644,6 @@ await server.AcceptConnectionAsync(async connection =>

[Theory]
[MemberData(nameof(Interim1xxStatusCode))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_Unexpected1xxResponses_DropAllInterimResponses(HttpStatusCode responseStatusCode)
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -2029,7 +2025,6 @@ await LoopbackServer.CreateServerAsync(async (server, url) =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_RequestVersion20_HttpNotHttps_NoUpgradeRequest()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -2065,7 +2060,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

#region Uri wire transmission encoding tests
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendRequest_UriPathHasReservedChars_ServerReceivedExpectedPath()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down
10 changes: 0 additions & 10 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Headers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public HttpClientHandlerTest_Headers(ITestOutputHelper output) : base(output) {
private sealed class DerivedHttpHeaders : HttpHeaders { }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_RequestWithSimpleHeader_ResponseReferencesUnmodifiedRequestHeaders()
{
const string HeaderKey = "some-header-123", HeaderValue = "this is the expected header value";
Expand Down Expand Up @@ -72,7 +71,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_LargeHeaders_CorrectlyWritten()
{
if (UseVersion == HttpVersion.Version30)
Expand Down Expand Up @@ -108,7 +106,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_DefaultHeaders_CorrectlyWritten()
{
const string Version = "2017-04-17";
Expand Down Expand Up @@ -170,7 +167,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
[InlineData("Accept-CharSet", "text/plain, text/json", false)] // invalid format for header but added with TryAddWithoutValidation
[InlineData("Content-Location", "", false)] // invalid format for header but added with TryAddWithoutValidation
[InlineData("Max-Forwards", "NotAnInteger", false)] // invalid format for header but added with TryAddWithoutValidation
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_SpecialHeaderKeyOrValue_Success(string key, string value, bool parsable)
{
if (PlatformDetection.IsBrowser && (key == "Content-Location" || key == "Date" || key == "Accept-CharSet"))
Expand Down Expand Up @@ -216,7 +212,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
[Theory]
[InlineData("Content-Security-Policy", 4618)]
[InlineData("RandomCustomHeader", 12345)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetAsync_LargeHeader_Success(string headerName, int headerValueLength)
{
var rand = new Random(42);
Expand All @@ -241,7 +236,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetAsync_EmptyResponseHeader_Success()
{
IList<HttpHeaderData> headers = new HttpHeaderData[] {
Expand Down Expand Up @@ -273,7 +267,6 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetAsync_MissingExpires_ReturnNull()
{
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Expand All @@ -294,7 +287,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
[InlineData("Thu, 01 Dec 1994 16:00:00 GMT", true)]
[InlineData("-1", false)]
[InlineData("0", false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_Expires_Success(string value, bool isValid)
{
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Expand Down Expand Up @@ -333,7 +325,6 @@ public void HeadersAdd_CustomExpires_Success(string value, bool isValid)

[Theory]
[InlineData("Accept-Encoding", "identity,gzip")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_RequestHeaderInResponse_Success(string name, string value)
{
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
Expand All @@ -358,7 +349,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
[Theory]
[InlineData(false)]
[InlineData(true)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task SendAsync_GetWithValidHostHeader_Success(bool withPort)
{
if (UseVersion == HttpVersion.Version30)
Expand Down
7 changes: 0 additions & 7 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ public async Task GetAsync_CustomException_Asynchronous_ThrowsException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetStringAsync_Success()
{
string content = Guid.NewGuid().ToString();
Expand All @@ -390,7 +389,6 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetStringAsync_CanBeCanceled_AlreadyCanceledCts()
{
var onClientFinished = new SemaphoreSlim(0, 1);
Expand All @@ -415,7 +413,6 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetStringAsync_CanBeCanceled()
{
var cts = new CancellationTokenSource();
Expand Down Expand Up @@ -542,7 +539,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetByteArrayAsync_Success()
{
string content = Guid.NewGuid().ToString();
Expand Down Expand Up @@ -587,7 +583,6 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetByteArrayAsync_CanBeCanceled()
{
var cts = new CancellationTokenSource();
Expand Down Expand Up @@ -618,7 +613,6 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetStreamAsync_Success()
{
string content = Guid.NewGuid().ToString();
Expand Down Expand Up @@ -666,7 +660,6 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetStreamAsync_CanBeCanceled()
{
var cts = new CancellationTokenSource();
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpContentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,6 @@ public void Dispose_DisposedObjectThenAccessMembers_ThrowsObjectDisposedExceptio


[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStringAsync_Buffered_IgnoresCancellationToken()
{
string content = Guid.NewGuid().ToString();
Expand Down Expand Up @@ -671,7 +670,6 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStringAsync_Unbuffered_CanBeCanceled()
{
var cts = new CancellationTokenSource();
Expand Down Expand Up @@ -709,7 +707,6 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsByteArrayAsync_Buffered_IgnoresCancellationToken()
{
string content = Guid.NewGuid().ToString();
Expand Down Expand Up @@ -768,7 +765,6 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsByteArrayAsync_Unbuffered_CanBeCanceled()
{
var cts = new CancellationTokenSource();
Expand Down Expand Up @@ -808,7 +804,6 @@ await server.AcceptConnectionAsync(async connection =>
[Theory]
[InlineData(true)]
[InlineData(false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStreamAsync_Buffered_IgnoresCancellationToken(bool readStreamAsync)
{
string content = Guid.NewGuid().ToString();
Expand Down Expand Up @@ -840,7 +835,6 @@ await LoopbackServer.CreateClientAndServerAsync(
[Theory]
[InlineData(true)]
[InlineData(false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStreamAsync_Unbuffered_IgnoresCancellationToken(bool readStreamAsync)
{
if(PlatformDetection.IsBrowser && !readStreamAsync)
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/HttpRequestMessageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task HttpRequest_BodylessMethod_LargeContentLength()
{
using (HttpClient client = CreateHttpClient())
Expand Down