Try Vector128 before Vector #89797
Merged
Try Vector128 before Vector #89797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-encoding Issue Detailsnull
|
kg
approved these changes
Aug 1, 2023
stephentoub
approved these changes
Aug 1, 2023
| @@ -109,6 +109,10 @@ internal static unsafe nuint GetIndexOfFirstNonAsciiByte(byte* pBuffer, nuint bu | |||
| { | |||
| return GetIndexOfFirstNonAsciiByte_Intrinsified(pBuffer, bufferLength); | |||
| } | |||
| else if (Vector128.IsHardwareAccelerated) | |||
There was a problem hiding this comment.
The above Sse2 or AdvSimd paths are the code paths that use Vector128 and are much more efficient than the associated Vector128 path.
I believe if it reaches this point, where we cannot use Vector512, Vector256, or Sse2/AdvSimd, then the Vector path itself will likely be as efficient and no need to call back into _Vector.
There was a problem hiding this comment.
We would prefer the Vector128 path for wasm
There was a problem hiding this comment.
Ok, understood. Thanks for the context.
tannergooding
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #88532 The code prefers Vector512/Vector256/AdvSimd but then falls back to Vector rather than Vector128 which is implemented in the _Vector method
(I didn't actually check the Vector128 path closely)