-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JIT] Do not force creation of a new IG if the current IG has no instructions #89876
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAt the moment, this is just adding the test. I'm not able to reproducer it, so let's see what CI says.
|
@dotnet/jit-contrib This is ready - @jakobbotsch - I added the test but it doesn't appear to fail CI - so it looks like the original issue is no longer an issue now. |
src/tests/JIT/Regression/JitBlue/Runtime_78891/Runtime_78891.cs
Outdated
Show resolved
Hide resolved
src/tests/JIT/Regression/JitBlue/Runtime_78891/Runtime_78891.cs
Outdated
Show resolved
Hide resolved
The problem still repros if you run with the following environment variables: $env:DOTNET_JitDoVNBasedDeadStoreRemoval=0
$env:DOTNET_JitEnableEarlyLivenessRange=0
$env:DOTNET_EnableAVX2=0
$env:DOTNET_JitEnablePhysicalPromotion=0 |
Does it not reproduce with AltJit, only an actual linux machine?
Edit: I didn't set DOTNET_TieredCompilation=0, once I did that I got it to repro. |
… enabling GC in the emitter, if the current IG has no instructions, do not force a new IG.
@jit-contrib @BruceForstall This is ready again, pending CI. |
I will look at this, but I'm suspicious of the fix. The code currently doesn't force a new IG; it sets emitForceNewIG to defer creating a new IG until needed. If there's a case where the current IG is empty then I would expect the logic to not create a new IG should be put where the |
I know where we can handle that check and actually did that before making this one. |
@BruceForstall I changed it where we check if there are instructions before emitting the next IG. |
#78891
Description
This PR simply makes it where we will not force a new IG if there are no instructions in the current one.