-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through ComWrappers based objects to COM type descriptor #89887
Conversation
WinForms hosts the the COM type descriptor. It has been updated to work with ComWrappers based objects- adding the check for them in TypeDescriptor. There are hard dependencies on Windows in the current implementation. We can potentially update to conditionalize these. dotnet/winforms#9291 tracks. There is no automated test as it would require adding a dependency upstream to WinForms.
Tagging subscribers to this area: @dotnet/area-system-componentmodel Issue DetailsWinForms hosts the the COM type descriptor. It has been updated to work with ComWrappers based objects- adding the check for them in TypeDescriptor. There are hard dependencies on Windows in the current implementation. We can potentially update to conditionalize these. dotnet/winforms#9291 tracks. There is no automated test as it would require adding a dependency upstream to WinForms. cc: @ericstj @AaronRobinsonMSFT
|
Can we copy a smaller portion of that code here to test - less as the "real scenario" and more as just a mock - or would that require too much duplication? |
@ericstj I think it would be more effort than is worth it. I've got tests for this already in WinForms, I just need to switch them over to get the converter from |
@JeremyKuhne Wouldn't it be possible to write a simple test that calls |
Maybe? It throws when WinForms isn't available, I'd have to handle all cases gracefully. I don't think this is likely to break and it will be caught when WinForms tries to update dependencies. |
Oh. Nevermind. I agree adding tests is probably not worth the effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for considering tests. I'm OK with the resolution to only test in WinForms.
Failing tests are known issues. |
WinForms hosts the the COM type descriptor. It has been updated to work with ComWrappers based objects- adding the check for them in TypeDescriptor.
There are hard dependencies on Windows in the current implementation. We can potentially update to conditionalize these. dotnet/winforms#9291 tracks.
There is no automated test as it would require adding a dependency upstream to WinForms.
cc: @ericstj @AaronRobinsonMSFT