Fix isIPAdjusted setting during exception handling #89930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CrawlFrame::isIPAdjusted flag is set to true for all frames when handling software exceptions. That is not correct, as the IP is not adjusted in those cases. I've also cleaned up the values the flag is set to at various places to use the real type of the member, which is `bool`. It was being set to TRUE / FALSE or even 0 / 1 at some places. As a related cleanup, I've removed the FRAME_ATTR_OUT_OF_LINE flag as it was never set anywhere and still was being tested at few places.
|
Let me actually add a regression test for the #89834 |
jkotas
approved these changes
Aug 3, 2023
This was referenced Aug 3, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CrawlFrame::isIPAdjusted flag is set to true for all frames when handling software exceptions. That is not correct, as the IP is not adjusted in those cases.
I've also cleaned up the values the flag is set to at various places to use the real type of the member, which is
bool. It was being set to TRUE / FALSE or even 0 / 1 at some places.As a related cleanup, I've removed the FRAME_ATTR_OUT_OF_LINE flag as it was never set anywhere and still was being tested at few places.
Close #89834