-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Http2Connection shutdown/dispose logic #90094
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsCloses #84767 Context: #84767 (comment)
This PR merges together the I also removed the
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I'm not too familiar with this logic.
Do you know if we have tests to cover the cases when request/response should working after Dispose?
I really thought we already had such a test, but I don't see it now. We have a different one where we dispose the I added a new test now that verifies that disposing the handler during a request is fine. |
Closes #84767
Context: #84767 (comment)
This PR merges together the
Dispose
&Shutdown
logic (dispose calls shutdown) since as far as I can see, they were doing the same thing.I also removed the
ShutdownWaiter
logic coordinating between the pool and connection, callingInvalidateHttp2Connection
directly instead.