Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some tests on macOS only due to small stack size #90116

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 7, 2023

Rationale: #87879 (comment)

This PR enables these tests back on non-macOS platforms + disables HugeArray1 on macOS since it hits the same issue too (e.g. in https://github.com/dotnet/runtime/runs/15626705312)

@ghost ghost assigned EgorBo Aug 7, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 7, 2023
@ghost
Copy link

ghost commented Aug 7, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Rationale: #87879 (comment)

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Aug 7, 2023

/azp list

@azure-pipelines

This comment was marked as resolved.

@EgorBo
Copy link
Member Author

EgorBo commented Aug 7, 2023

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr pgostress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented Aug 8, 2023

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr pgostress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented Aug 8, 2023

@jkotas @jakobbotsch PTAL - this PR doesn't "resolve" #87879 but there is no need in disabling the tests for all platforms when only mac is affected

@EgorBo EgorBo merged commit 32a8c2d into dotnet:main Aug 9, 2023
@EgorBo EgorBo deleted the ignore-tests branch August 9, 2023 01:30
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants