-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] download sequence optimization #90388
[browser] download sequence optimization #90388
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
@radekdoulik could you please measure this on your bench before we merge it ? To see if this helps with AOT and cold start. |
@maraf , please consider also adding |
Also with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me assuming it improves things.
- disable throttling in perf bench
- fixed loading .wasm always - calling LibraryInitializers and onConfigLoaded for manual config too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but there are some parts I don't completely understand the significance of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5998747142 |
@pavelsavara backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: attempt
Applying: oh whitespace!
Applying: - resolve memorySnapshotSkippedOrDone earlier
Applying: fix minimal sample
Applying: - moved checking for snapshot to `configureRuntimeStartup`
error: sha1 information is lacking or useless (src/mono/wasm/runtime/startup.ts).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0005 - moved checking for snapshot to `configureRuntimeStartup`
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@pavelsavara an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
startupMemoryCache
false or memory cache is empty, we could fetch DLLs earlierconfigureRuntimeStartup
onConfigLoaded
for manual config tooRelated #89631 #89857 #89687 dotnet/aspnetcore#49909