Replace Utf16Utility.GetPointerToFirstInvalidChar fallback with Vector128 #90391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r128 The else block will only be used on platforms where `Vector<T>` is 128-bit, so just use Vector128 explicitly.
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-encoding Issue DetailsThe else block will only be used on platforms where
|
EgorBo
reviewed
Aug 11, 2023
src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs
Outdated
Show resolved
Hide resolved
EgorBo
approved these changes
Aug 11, 2023
|
Is |
Yes |
|
@stephentoub Could you also take a look at |
I already did. |
tannergooding
approved these changes
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The else block will only be used on platforms where
Vector<T>is 128-bit, so just use Vector128 explicitly.