-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-rc1] [mono][ios] Revert LLVM mode for apple mobile tests #90624
[release/8.0-rc1] [mono][ios] Revert LLVM mode for apple mobile tests #90624
Conversation
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsBackport of #90586 to release/8.0-rc1 /cc @kotlarmilos Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Tagging subscribers to this area: @directhex Issue DetailsBackport of #90586 to release/8.0-rc1 /cc @kotlarmilos Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
@carlossanlop this is an infra change that impacts the test build. |
PR: #90586
Description
Backport of #90586 to release/8.0-rc1
This PR reverts the default setting of using Mono AOT LLVM compilation for Apple mobile tests. The regression was introduced in #87773 which refactored a CI pipeline. The expected behavior was to AOT compile runtime and functional tests using Mono AOT LLVM runtime, but instead, Mono AOT mini runtime is used.
The fix for this issue includes passing MonoEnableLLVM property.
Customer Impact
The issue was discovered by a team member.
Testing
Manual testing and an automated testing on the CI were performed, ensuring that the Mono AOT LLVM runtime is used. The issue has been reproduced locally, and has been fixed.
Risk
Low risk. This change involves passing an additional parameter when executing runtime and functional tests on Apple mobile platforms.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
The change doesn't affect code that ships in a NuGet package.