[release/8.0-rc1] Fix problems with Assembler::ReflectionNotation()
#90655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Do more parameter validation, correct buffer size calculations for security-enhanced CRT functions, and avoid memcpy buffer overrun of locale.
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #90565 to release/8.0-rc1 /cc @BruceForstall Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@BruceForstall can you please fill out the template? cc @jeffschwMSFT for approval when ready. PS: Don't press the "Update branch" button, or the CI will restart. Ping me when ready to merge and I can bypass the restriction and merge it. |
TIHan
approved these changes
Aug 16, 2023
jeffschwMSFT
approved these changes
Aug 16, 2023
carlossanlop
added
the
Servicing-consider
|
Approved by Tactics via email. |
carlossanlop
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90565 to release/8.0-rc1
/cc @BruceForstall
Customer Impact
Fixes buffer overrun case with too-long
locale.Testing
ilasm round-trip pipeline, plus manual testing of failure case.
Risk
Low