Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid PGO optimization path on Nuget cache containing spaces. #90729

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix invalid PGO optimization path on Nuget cache containing spaces. #90729

merged 1 commit into from
Sep 12, 2023

Commits on Aug 17, 2023

  1. Fix invalid PGO optimization path on Nuget cache containing spaces. 

    Since CMD does not strip quotes from arguments passed in with quotes
by default, if a Nuget package cache path containing a space is
passed to build-runtime.cmd, it will pass it into an additional CMake
argument with an additional set of quotes.

This causes string semantics to be disabled upon reaching the
second opening quote, thus separating the cache path into two
separate arguments incorrectly, resulting in the PGO data optimization
pointing to an invalid path.

This patch fixes this issue by simply removing the redundant quotes
when accepting the arguments in build-runtime.cmd.
    @c272
    c272 committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    da4a63a View commit details
    Browse the repository at this point in the history