Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] HTTP & SSL Stress: Run nightlies against release/8.0 #90809

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2023

Backport of #90808 to release/8.0

/cc @antonfirsov

Customer Impact

Test-only change in optional pipelines to enable nightly stress runs against release/8.0. We need this for QA of our HTTP stack in 8.0.

Testing

N/A

Risk

N/A

@ghost
Copy link

ghost commented Aug 18, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90808 to release/8.0

/cc @antonfirsov

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra only, so tell-mode. Approved.

Do you not want this in RC1? The branch that is currently being targeted is RC2.

If you want RC1, please edit the PR title and retarget to the branch release/8.0-rc1.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 18, 2023
@antonfirsov
Copy link
Member

antonfirsov commented Aug 18, 2023

Do you not want this in RC1

We would need to add a line for release/8.0-rc to the yaml-s on all branches. Since release/8.0 and release/8.0-rc Networking code is currently identical, I think this would only create unnecessary complexity, test run noise and follow-up work to remove it after GA. In case we end up backporting some non-trivial changes, we can enable the pipeline for RC1 at that point. @dotnet/ncl any pushback?

@antonfirsov
Copy link
Member

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member

/azp run runtime-libraries stress-ssl

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

Too late to merge to RC1 anyway. The builds have started. RC2 will have to suffice.

@wfurt
Copy link
Member

wfurt commented Aug 18, 2023

not urgent IMHO. We just want to be sure we do not loose test coverage @carlossanlop

@carlossanlop carlossanlop merged commit 90b92bb into release/8.0 Aug 19, 2023
102 of 106 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90808-to-release/8.0 branch August 19, 2023 00:06
@antonfirsov
Copy link
Member

Looks like this PR and #90808 were insufficient to enable automatic nightly runs of the runtime-libraries stress-http and runtime-libraries stress-ssl pipelines against release/8.0. The PR-s were merged 3 days ago, yet the only run I see is the one triggered in this PR.

@dotnet/dnceng any idea what am I doing wrong?

@chcosta
Copy link
Member

chcosta commented Aug 21, 2023

Do you believe there's an outage preventing your automated run or is it possible something is improperly configured? #90808 appears to be targeting main. Is it possible that is the reason the release/8.0 run did not trigger or are you expecting a different behavior?

@antonfirsov
Copy link
Member

@chcosta the pipelines have been scheduled for today, fingers crossed it was a glitch over the weekend and the nightly runs will become regular. Otherwise expect me to come back for help, since I'm not an expert on AZP and don't have a deep understanding on schedules.cron.

@karelz karelz added this to the 8.0.0 milestone Aug 29, 2023
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants