Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix config names for CallCountThreshold and CallCountingDelayMs #90841

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2023

Backport of #90799 to release/8.0

/cc @EgorBo

Customer Impact

No impact, these config knobs were not yet surfaced, but in my previous attempt I didn't figure out there are existing config knobs for tiered compilation and they have a different naming convention 😞 . e.g. https://github.com/dotnet/sdk/blob/62d3e897cce38a3df8d0ff4eb489a3f2e16f6dce/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L604-L611.

Testing

Risk

No risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@EgorBo
Copy link
Member

EgorBo commented Aug 19, 2023

@mangod9 PTAL backported fix, thanks

@carlossanlop
Copy link
Member

@jeffschwMSFT can we get your blessing?

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. once ready this can be merged

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 23, 2023
@carlossanlop carlossanlop merged commit ebbc4ce into release/8.0 Aug 23, 2023
110 of 112 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90799-to-release/8.0 branch August 23, 2023 21:39
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants