[release/8.0] Events for IL methods without IL headers #90844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Dynamically generated methods like UnsafeAccessor functions are marked as IL, but don't contain an IL header. The lack of header is an indication the IL must be generated at runtime.
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
jkotas
approved these changes
Aug 19, 2023
AaronRobinsonMSFT
added
the
Servicing-consider
|
This reverts changes from rc1 - #90818. |
The crash is triggered by combination when all of the following are true:
I do not think that this is RC1 blocking issue. @jeffschwMSFT ? |
jeffschwMSFT
approved these changes
Aug 19, 2023
|
last changes for rc1 were late last week. so unless this is a main line issue, we should fix in rc2 |
AaronRobinsonMSFT
added
Servicing-approved
|
@jkotas or @jeffschwMSFT The CI is green, please merge when convenient. |
|
/backport to release/8.0-rc1 |
|
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6242340304 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90826 to release/8.0
/cc @AaronRobinsonMSFT
Customer Impact
This failure represents a potential crash when events are enabled. It is possible the process will crash randomly without this change.
Testing
The failure was predictable and occurred regularly (> 90 %) after a change to adopt it within the runtime.
Risk
Minimal. This is adding a null check in more places that already handle returning null.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.