Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update Microsoft.Extensions.Http.cs #90920

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2023

Backport of #90916 to release/8.0

Fixes #90911

/cc @CarnaViire @ShreyasJejurkar

Customer Impact

The new 8.0 API ConfigureHttpClientDefaults introduced in #87914 (PR #87953 merged on 7/14) was supposed to be extension method, but this was by accident omitted from ref (it was correctly part of implementation of the API).

Note: api-compat tool didn't catch the discrepancy, although it should have. We created a new issue dotnet/sdk#34824 to address it for future cases.

Testing

CI + manual inspection of ref assembly

Risk

Very low, this is a new feature introduced in 8.0

Update ref, add missing `this` to extension method parameter
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 22, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90916 to release/8.0

/cc @CarnaViire @ShreyasJejurkar

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-HttpClientFactory

Milestone: -

@karelz karelz added this to the 8.0.0 milestone Aug 22, 2023
@CarnaViire CarnaViire self-assigned this Aug 22, 2023
@karelz
Copy link
Member

karelz commented Aug 22, 2023

I am giving M2 approval -- this is a new 8.0 API, where ref is not correct, which makes it harder to use.
Fix is simple, low risk and was validated.

@carlossanlop do you need anything else from us?

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 22, 2023
@carlossanlop carlossanlop merged commit d727d86 into release/8.0 Aug 22, 2023
106 of 114 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90916-to-release/8.0 branch August 22, 2023 19:40
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants