Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete some dead code` #91018

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Delete some dead code` #91018

merged 1 commit into from
Aug 24, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 23, 2023

No description provided.

@ghost ghost assigned jkotas Aug 23, 2023
@jkotas jkotas requested a review from VSadov August 23, 2023 20:35
@jkotas
Copy link
Member Author

jkotas commented Aug 23, 2023

Leftover from #89548

@VSadov
Copy link
Member

VSadov commented Aug 23, 2023

As I remember fClassMustBeRestored was removed in the big change (and that part was not causing any issues), but later was undone together with all JIT changes.

@jkotas
Copy link
Member Author

jkotas commented Aug 23, 2023

Right

VSadov
VSadov approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkotas jkotas mentioned this pull request Aug 24, 2023
Closed
@jkotas jkotas merged commit b0d2596 into dotnet:main Aug 24, 2023
@jkotas jkotas deleted the class-must-be-restored branch August 24, 2023 00:26
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VSadov VSadov VSadov approved these changes

Assignees

@jkotas jkotas

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @VSadov