Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [browser] Update browser template to use Wasm SDK #91046

Merged
merged 17 commits into from
Aug 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 24, 2023

Backport of #90871 to release/8.0

/cc @maraf

Customer Impact

Customers using wasmbrowser template leverage the new WebAssembly SDK

Testing

Automated unit tests in Wasm.Build.Tests suit

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@maraf maraf requested a review from marek-safar August 24, 2023 07:36
@maraf maraf added the Servicing-consider Issue for next servicing release review label Aug 24, 2023
@maraf maraf added this to the 8.0.0 milestone Aug 24, 2023
@maraf maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90871 to release/8.0

/cc @maraf

Customer Impact

Customers using wasmbrowser template leverage the new WebAssembly SDK

Testing

Automated unit tests in Wasm.Build.Tests suit

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Build-mono, os-browser

Milestone: 8.0.0

@carlossanlop
Copy link
Member

@maraf this needs M2 approval. @lewing / @steveisok / @marek-safar do you approve?

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 29, 2023
@carlossanlop
Copy link
Member

Wow! If @lewing and @kg give their sign-off too, it will be like a WASM Royal Flush 😄

@carlossanlop carlossanlop merged commit 028b380 into release/8.0 Aug 30, 2023
32 of 38 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90871-to-release/8.0 branch August 30, 2023 19:43
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants