[release/8.0] [mono] Handle enum return type when inlining CreateInstance #91061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91008 to release/8.0
/cc @fanyang-mono @uweigand
Customer Impact
Mono has the logic to inline the call to System.Activator.CreateInstance(). Prior to this change, Mono always assumed
T
as non-primitive type. However, for the customer reported situation,T
was a enum type. Treating it as non-primitive type led to incorrect generated code. That triggered an assertion during runtime.Testing
The customer confirmed that with this change, the assertion went away and the generated code was correct. All CI lanes were passed as well.
Risk
Adding a new scenario that Mono wasn't considering before. Thus, the risk of breaking existing functionality is very low.