Recommend [In] and [Out] attributes on array parameters #91094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
requested review from
jkoritzinsky,
AaronRobinsonMSFT and
elinor-fung
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsAdds an info diagnostic for interop generators that nudges users to add [In] or [Out] attributes to arrays. Ensures only arrays are allowed to have [In] or [Out] attributes. Previously, other pinned custom collections would allow them. Separates tests related to [In] and [Out] attributes to their own files in both unit test projects. Moves some shared test utilities to shared code (ID(), GetCallerLineNumber())
|
jkoritzinsky
approved these changes
Aug 24, 2023
AaronRobinsonMSFT
approved these changes
Aug 25, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6004060617 |
|
@jtschuster backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: wip
Using index info to reconstruct a base tree...
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.es.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.fr.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.it.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.ja.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.ko.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.pl.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.pt-BR.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.ru.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.tr.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.zh-Hans.xlf
M src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.zh-Hant.xlf
M src/libraries/System.Runtime.InteropServices/tests/TestAssets/SharedTypes/SharedTypes.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime.InteropServices/tests/TestAssets/SharedTypes/SharedTypes.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Runtime.InteropServices/tests/TestAssets/SharedTypes/SharedTypes.csproj
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.zh-Hant.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.zh-Hans.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.tr.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.ru.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.pt-BR.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.pl.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.ko.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.ja.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.it.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.fr.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.es.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf
Auto-merging src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 wip
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@jtschuster an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
jtschuster
added a commit
to jtschuster/runtime
that referenced
this pull request
Aug 28, 2023
…parameters (dotnet#91094) Recommend that methods with array parameters use [In] or [Out] attributes if there are none already, and the parameter is not in, ref, or out.
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90884
Adds an info diagnostic for interop generators that nudges users to add [In] or [Out] attributes to arrays.
Ensures only arrays are allowed to have [In] or [Out] attributes. Previously, other pinned custom collections would allow them.
Separates tests related to [In] and [Out] attributes to their own files in both unit test projects.
Moves some shared test utilities to shared code (ID(), GetCallerLineNumber())