Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crossgen2 from source build intermediate package #91122

Closed

Conversation

agocke
Copy link
Member

@agocke agocke commented Aug 25, 2023

Symbol size is causing the package to blow feed size limit restrictions

Symbol size is causing the package to blow feed size limit restrictions
@ghost
Copy link

ghost commented Aug 25, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Symbol size is causing the package to blow feed size limit restrictions

Author: agocke
Assignees: agocke
Labels:

area-Infrastructure-libraries

Milestone: -

@agocke agocke requested a review from mmitche August 25, 2023 16:31
@@ -62,11 +62,6 @@

<IntermediateNupkgArtifactFile Include="$(CurrentRepoSourceBuildArtifactsPackagesDir)Shipping\*Microsoft.DotNet.ILCompiler.*.nupkg" Category="ILCompiler" />

<IntermediateNupkgArtifactFile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is going to achieve what you want. IIRC, all packages that are not included in supplemental packages get included in the default master package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Matt's working on an alternative. Closing this one.

@agocke agocke closed this Aug 25, 2023
@agocke agocke deleted the exclude-crossgen-sourcebuild-package branch August 25, 2023 21:33
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants