Remove some unused headers and functions #91177
Conversation
ghost
added
the
community-contribution
| #ifndef HOST_UNIX | ||
| #include <verrsrc.h> | ||
| #endif |
There was a problem hiding this comment.
The custom .rc parser on Unix seems honoring #include rule, but does not looks into the actual content of macros. Do we need a comment for it?
There was a problem hiding this comment.
If this ifdef is tricky, a comment would be useful.
There was a problem hiding this comment.
I am not sure I understand what you mean by "doesn't inspect the actual values of the macros". The parser first runs the resource file through the C preprocessor, so it should process all macros should be expanded to their values during that phase.
There was a problem hiding this comment.
I didn't look depth about how the parser works and how it works, but it seems that palrt.h doesn't bring any macro used. I'll update the comment.
|
Going to push more today |
|
This one is ready for review now. @janvorli any interest? |
|
Is this fine now? |
No description provided.