Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_ManagedThreadId FCall #91232

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Remove get_ManagedThreadId FCall #91232

merged 2 commits into from
Aug 28, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 28, 2023 •
edited
Loading 

int Foo(Thread t) => t.ManagedThreadId;

Was:

mov      rcx, rdx
cmp      dword ptr [rcx], ecx
jmp      System.Threading.Thread:get_ManagedThreadId():int:this

Now:

mov      eax, dword ptr [rcx+0x34]
ret

@ghost ghost assigned EgorBo Aug 28, 2023
@EgorBo EgorBo merged commit 4c01386 into dotnet:main Aug 28, 2023
@EgorBo EgorBo deleted the opt-managedthreadid branch August 28, 2023 23:06
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@EgorBo EgorBo

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @jkotas