Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add Retry and Task.Delay to WinHttpHandler AfterReadResponseServerError_ClientWrite test #91271

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2023

Backport of #90824 to release/8.0

Fixes #86262

/cc @liveans

Customer Impact

Test-only change to decrease noise in CI (2-3/day failure in main and sometimes even more).

Testing

Observed CI main runs for ~7-8 days without any failures (previously 2-3/day failures and sometimes even more).

Risk

None. Test-only change.

@ghost
Copy link

ghost commented Aug 29, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90824 to release/8.0

/cc @liveans

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@karelz
Copy link
Member

karelz commented Aug 29, 2023

I am giving M2 approval -- this is test-only change, which addressed 2-3 failures per day in CI in main.
Marking as Servicing-approved

cc @artl93 @carlossanlop

@karelz karelz added the Servicing-approved Approved for servicing release label Aug 29, 2023
@carlossanlop carlossanlop merged commit bbaba10 into release/8.0 Aug 29, 2023
106 of 112 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90824-to-release/8.0 branch August 29, 2023 17:15
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
4 participants