Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [nodejs] Remove experimental wasm arguments from template #91401

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 31, 2023

Backport of #91384 to release/8.0

/cc @maraf

Customer Impact

Customers using newer Node won't need to remove unsupported parameters from the template. For customers with older Node we have a user friendly error message with link to guidance.

Testing

Manual.

Risk

Low.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono and removed area-VM-meta-mono labels Aug 31, 2023
@maraf maraf added this to the 8.0.0 milestone Aug 31, 2023
@ghost
Copy link

ghost commented Aug 31, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91384 to release/8.0

/cc @maraf

Customer Impact

Customers using newer Node won't need to remove unsupported parameters from the template. For customers with older Node we have a user friendly error message with link to guidance.

Testing

Manual.

Risk

Low.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@maraf maraf requested a review from marek-safar August 31, 2023 19:13
@maraf maraf added the os-browser Browser variant of arch-wasm label Aug 31, 2023
@carlossanlop
Copy link
Member

@lewing do you approve?
@pavelsavara can you please provide a code-review sign-off?

@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Aug 31, 2023
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 1, 2023
@carlossanlop
Copy link
Member

CI failure is #90639

@carlossanlop carlossanlop merged commit dc652c1 into release/8.0 Sep 1, 2023
31 of 35 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91384-to-release/8.0 branch September 1, 2023 18:31
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants