[PERF] Remove browser wasm from perf_slow #91429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @directhex Issue DetailsLooking into an error with build Browser Wasm on our Linux arm64 machines, I found that the build was not being used. While this PR removes the build from perf_slow, this is also a PR to verify that we are running the correct cases for perf_slow. Here is a test run verifying that the pipeline does not have any further dependency on the BrowserWasm build by being able to start the pipeline at all: https://dev.azure.com/dnceng/internal/_build/results?buildId=2256450&view=results. @radical do you know if running through v8 on the arm machines is something we want coverage for?
|
cincuranet
approved these changes
Sep 4, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into an error with build Browser Wasm on our Linux arm64 machines, I found that the build was not being used. While this PR removes the build from perf_slow, this is also a PR to verify that we are running the correct cases for perf_slow. Here is a test run verifying that the pipeline does not have any further dependency on the BrowserWasm build by being able to start the pipeline at all: https://dev.azure.com/dnceng/internal/_build/results?buildId=2256450&view=results. @radical do you know if running through v8 on the arm machines is something we want coverage for?