Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Linq CountBy method for IEnumerable and IQueryable #91507

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Implement Linq CountBy method for IEnumerable and IQueryable #91507

merged 8 commits into from
Sep 14, 2023

Conversation

manandre
Copy link
Contributor

@manandre manandre commented Sep 2, 2023

Closes #77716

@epeshk I started from your initial commit 793c97a and I made required changes to respect approved API
Your comments are welcome indeed.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 2, 2023
@ghost
Copy link

ghost commented Sep 2, 2023

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #77716

@epeshk I started from your initial commit 793c97a and I made required changes to respect approved API
Your comments are welcome indeed.

Author: manandre
Assignees: -
Labels:

area-System.Linq, new-api-needs-documentation
Milestone: -

@eiriktsarpalis eiriktsarpalis mentioned this pull request Sep 5, 2023
Closed
@eiriktsarpalis eiriktsarpalis added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 5, 2023
@eiriktsarpalis eiriktsarpalis removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 12, 2023
@build-analysis build-analysis bot mentioned this pull request Sep 13, 2023
Closed
@eiriktsarpalis eiriktsarpalis self-assigned this Sep 14, 2023
eiriktsarpalis
eiriktsarpalis approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @manandre would you be interested in contributing the AggregateBy implementation as well? It should be pretty similar to this one.

@eiriktsarpalis eiriktsarpalis merged commit 4b75f93 into dotnet:main Sep 14, 2023
@manandre manandre deleted the countby branch September 14, 2023 19:55
This was referenced Sep 14, 2023
Closed
Closed
@manandre manandre mentioned this pull request Sep 16, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@stephentoub stephentoub stephentoub left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Linq community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Linq CountBy method
4 participants
@manandre @stephentoub @eiriktsarpalis @huoyaoyuan