-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate hardcoded offsets to PROFILE_PLATFORM_SPECIFIC_DATA struct #91595
Validate hardcoded offsets to PROFILE_PLATFORM_SPECIFIC_DATA struct #91595
Conversation
These offsets are now in asmconstants.h validated against the C struct with static asserts.
@davmason Can you have a look please? |
Thanks |
I think I need some time to refactor some function to fix some errors for LoongArch. Maybe tomorrow is ok. Or you just merge this PR liking your headline said this is just a refacting I will fix some errors within the profiler.cpp and the struct fields later by a new PR. |
It's OK with me to merge this as-is and fix LoongArch specifics later. BTW, from what I noticed ELT profiler on LoongArch64 isn't called at all, |
Tagging subscribers to this area: @tommcdon Issue DetailsThese offsets are now in asmconstants.h validated against the C struct with static asserts. This refactoring is a follow-up to discussion under PR #91313. Note: I didn't define offset constants for i386 because its asm profile stubs are based on a sequence of Part of #84834
|
Thank you! |
These offsets are now in asmconstants.h validated against the C struct with static asserts.
This refactoring is a follow-up to discussion under PR #91313.
Note: I didn't define offset constants for i386 because its asm profile stubs are based on a sequence of
push
es rather than field offsets so they wouldn't use them.Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @clamp03