[release/8.0] [maccatalyst] Make sure MacProxy is included in System.Net.Http #91599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
#90258 identified that `HttpClient.DefaultProxy` returned `System.Net.Http.HttpNoProxy` when using MacCatalyst. This is due to a condition in System.Net.Http.csproj not including maccatalyst as a condition and as a result, skipped adding the MacProxy sources. Way back when, #47823 had the condition, but this appears to have changed in #48652 when we thought MacCatalyst would inherit settings from iOS. That turned out to not be the case and this check was never added back.
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #91473 to release/8.0 /cc @steveisok Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
marek-safar
approved these changes
Sep 11, 2023
carlossanlop
approved these changes
Sep 11, 2023
carlossanlop
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91473 to release/8.0
Fixes #90258
/cc @steveisok
Customer Impact
A customer reported #90258 where they were using
ClientWebSocket.ConnectAsyncin their MAUI app behind a proxy server and ran into connection issues using MacCatalyst. This is due to an in incorrect condition inSystem.Net.Http.csprojthat does not include the relevant source code.Testing
Manually validated connection with a proxy works
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.