[release/8.0] Remove DebugProxy from ClaimsIdentity and ClaimsPrincipal #91680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsBackport of #91649 to release/8.0 /cc @jozkee Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
This was referenced Sep 6, 2023
jeffhandley
approved these changes
Sep 7, 2023
jeffhandley
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91649 to release/8.0
/cc @jozkee
Customer Impact
Fixes a subtle regression introduced on #86424.
The debugger experience for the derived types of ClaimsPrincipal and ClaimsIdentity would only show the properties in the DebugProxy types and hide the ones previously shown in the default view.
This can be observed on WindowsPrincipal and WindowsIdentity, but there are also third-parties extending from these types.
Testing
I buiit locally and verified that the previous view was back in place while keeping the [DebuggerDisplay] behavior that was also added in #86424.
Risk
Low.