Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BundlerConsistencyTests stop building/copying self-contained project unnecessarily #91829

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

elinor-fung
Copy link
Member

BundlerConsistencyTests were building a self-contained project and copying it for each test case. They are targeting the Bundler API and don't actual need a full app - just validation of how things get bundled and added to the manifest.

  • Add a HelloWorld project for as a pre-built test asset for host tests
  • Make BundlerConsistencyTests use a pre-built app and shared framework files instead of building/copying a self-contained project
  • Move the one test TestWithAdditionalContentAfterBundleMetadata that actually runs the bundled app into BundleAndRun

Contributes to #91039 - the other two test classes related to that issue are:

@elinor-fung elinor-fung added test-enhancement Improvements of test source code area-Single-File labels Sep 9, 2023
@ghost ghost assigned elinor-fung Sep 9, 2023
@ghost
Copy link

ghost commented Sep 9, 2023

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

BundlerConsistencyTests were building a self-contained project and copying it for each test case. They are targeting the Bundler API and don't actual need a full app - just validation of how things get bundled and added to the manifest.

  • Add a HelloWorld project for as a pre-built test asset for host tests
  • Make BundlerConsistencyTests use a pre-built app and shared framework files instead of building/copying a self-contained project
  • Move the one test TestWithAdditionalContentAfterBundleMetadata that actually runs the bundled app into BundleAndRun

Contributes to #91039 - the other two test classes related to that issue are:

Author: elinor-fung
Assignees: -
Labels:

test-enhancement, area-Single-File

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elinor-fung elinor-fung merged commit 9d08b24 into dotnet:main Sep 11, 2023
@elinor-fung elinor-fung deleted the bundlerConsistencyTests branch September 11, 2023 15:39
@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Single-File test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants