Replace http.error.reason with OTel standard error.type

[antonfirsov]

Fixes #91909

Align attribute name and semantics with the OpenTelemetry spec (which was finalized yesterday 2023/9/11 - see open-telemetry/semantic-conventions#205) -- http.error.reason attribute has been standardized under name error.type. We need to:

• Rename http.error.reason to error.type.
• Report error.type also for valid responses where the HTTP status code indicates an error (4xx or 5xx) -- in such case, the value should be the string representation of the HTTP status code.
  • Note: Currently we report http.error.reason only when the underlying handler fails to fetch a response.

See error.type in the spec for more details.

For context: We introduced the attribute http.error.reason in PR #89809 (on 2023/8/3) based on the in-progress draft of the OTel spec (open-telemetry/semantic-conventions#205).

Given that this is new 8.0 feature, we should adapt to the spec in 8.0 to avoid breaking changes with 9.0.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Address #91909. This PR should be only merged if we its' 8.0 servicing counterpart will be also approved, which I plan to open soon.

Author:	antonfirsov
Assignees:	antonfirsov
Labels:	area-System.Net.Http
Milestone:	-

[danmoseley]

Is there any similar change needed in Kestrel @JamesNK

[JamesNK]

No aspnetcore changes are required. This attribute is for HTTP clients only.

[danmoseley]

Ok. Yes sounds like we should definitely get into 8.0 as suggested

[karelz]

Let's get this into 9.0 first, then we can immediately create backport to 8.0. IMO it should not have a problem to get in.

@artl93 heads up. If you have concerns, please let us know ASAP.

[karelz]

@MihaZupan @noahfalk can you please code review, so that we can initiate the backport?
Thanks!

[MihaZupan]

Looks good, thank you

[lmolkova]

[antonfirsov]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[noahfalk]

Looks great 👍

[antonfirsov]

CI failures are #90639, #91910 + many unrelated failures in runtime-extra-platforms.

[antonfirsov]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6172076292