[release/8.0] dumpwriterelf: increase buffer to fit a RHEL8 arm64 page. #91953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This fixes out-of-bounds access when trying to write the diagnostics info on platforms where the PAGE_SIZE is larger than the DumpWriter's 16KiB m_tempBuffer.
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #91865 to release/8.0 /cc @mikem8361 @tmds Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@jeffschwMSFT can you approve? Thanks. |
jeffschwMSFT
approved these changes
Sep 12, 2023
hoyosjs
approved these changes
Sep 12, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91865 to release/8.0
/cc @mikem8361 @tmds
Customer Impact
Dump generation segfaults on architecture with 64K pages (RHEL arm64, macOS M1, etc).
Issue: #91864
Testing
Local testing by @tmds
Risk
Very low. Only affects runtime dump generation.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.