Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix si.ibAllocated in FrozenObjectHeapManager #92023

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix si.ibAllocated in FrozenObjectHeapManager #92023

merged 2 commits into from
Sep 14, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Sep 13, 2023 •
edited
Loading

ibAllocated is expected to be a real size of a segment, not a pointer to the end.

Regressed in #90847

@ghost ghost assigned EgorBo Sep 13, 2023
@EgorBo EgorBo requested a review from cshung September 13, 2023 20:41
@EgorBo
Copy link
Member Author

EgorBo commented Sep 13, 2023

PTAL @cshung @tommcdon, thanks for help!

cshung
cshung approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

tommcdon
tommcdon approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysis build-analysis bot mentioned this pull request Sep 14, 2023
Closed
@EgorBo EgorBo merged commit 62e50b6 into dotnet:main Sep 14, 2023
@EgorBo
Copy link
Member Author

EgorBo commented Sep 14, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6184382445

@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cshung cshung cshung approved these changes

@tommcdon tommcdon tommcdon approved these changes

Assignees

@EgorBo EgorBo

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorBo @cshung @tommcdon